-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMM: Build CUDA 12 packages #1223
Conversation
I'm looking at the CI output from the CUDA 12 C++ builds. We'll want to fix the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up on the cuda-python
run_exports
discussion, do we want this?
Edit: Ok punting on these if preferred
Co-authored-by: jakirkham <jakirkham@gmail.com>
@jakirkham Should
We solved that issue in
edit: I recall there may be an issue with run exports when used in this way... if I remember correctly, putting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would suggest adding cuda-cudart-dev
to host
for librmm-test
. Something like the snippet below may do the trick
Co-authored-by: jakirkham <jakirkham@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully the last review! I noticed a couple of things I missed before.
cuda: "12.0" | ||
packages: | ||
- &cuda_python12 cuda-python>=12.0,<13.0 | ||
- matrix: # All CUDA 11 versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, let's come back to this after we resolve the dfg work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming CI passes, we look good to go! Awesome work @bdice!
/merge |
Thanks all! 🙏 |
Description
This PR builds
librmm
andrmm
conda packages using CUDA 12. Resolves #1207.Checklist